[KPhotoAlbum] Fwd: Re: gps search: a patch

Reimar Imhof Reimar.Imhof at netcologne.de
Sun Jun 21 21:26:35 CEST 2015


Hi Tobias,

so I feel invited to run a patches kphotoalbum.

I've attached another patch. It fixes the gps position access from the exif 
db.
Most imported change is, that
Exif::Database::readFields( const DB::FileName& fileName, ElementList &fields) 
const
now returns a boolean: "Do we have any info about that file?"
If not, the caller in
KGeoMap::GeoCoordinates DB::ImageInfo::coordinates() const
should just assume there is no gps position and must not try to convert exif 
info to latest version because there is no exif info at all. Doing so prevents 
us from a lot of dummy entries in die exif-info.db
It's just some kind of paranoia the readFields delivers dummy objects in case 
there is no exif info at all.
Without this patch the exif info objects ("fields") did still hold the info 
from the last file with exif info. That did result in images/videos without 
exif info showing up with an gps position of another image. That really looked 
strange!

Cheers
Reimar


Am Samstag, 20. Juni 2015, 19:53:05 schrieb Tobias Leupold:
> Hi Reimar!
> 
> Speaking of the setLastCenterButton: as said, it's actually not meaningful
> to have it there, as no last center is set on the search map. This only
> happens if a single image is shown on the map, which is not the case
> (someone correct me if this is not the case!).
> 
> One can argue about the map centering. I personally think it's better to see
> the whole map when opening the search dialog. Anybody who is thinking it
> should be better reverted can feel free to do so ;-)
> 
> Cheers, Tobias
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum
-------------- next part --------------
A non-text attachment was scrubbed...
Name: exifRead.patch
Type: text/x-patch
Size: 3110 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150621/9e7ccd37/attachment.bin>


More information about the KPhotoAlbum mailing list