[KPhotoAlbum] More patches

Robert Krawitz rlk at alum.mit.edu
Sat Aug 8 21:44:31 CEST 2015


On Sat, 8 Aug 2015 06:38:20 +0300, Miika Turkia wrote:
> On Sat, Aug 8, 2015 at 6:18 AM, Robert Krawitz <rlk at alum.mit.edu> wrote:
>> Here are the rest of my patches (hopefully clearing out my queue).
>
> When creating the patches, you could use 'git format-patch HEAD~6' (or
> origin/master instead of the HEAD~<count>). This way it will be easy
> to use 'git am' to merge it to other git tree and author information
> will be correct. And more importantly, you get to write the commit
> message :D
>
> Of course, who is adding these patches can also use --author parameter
> on the commit to mark them properly as your patches.
>
> BTW it looks like the patches are reversed, and the ignore-empty-input
> includes also the aspect-ratio patch.
>
> -           if (m_currentInput == QString::fromLatin1(""))
> -               return;
>
> You could write this as: if (m_currentInput.isEmpty())
> http://doc.qt.io/qt-5/qstring.html#isEmpty

Here are all of the patches via git format-patch.
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Upper-case-tokens-in-thumbnail-view-tag-all-members-.patch
Type: application/octet-stream
Size: 2484 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150808/f31e10b3/attachment-0005.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-link-images-to-context-menu.patch
Type: application/octet-stream
Size: 5541 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150808/f31e10b3/attachment-0006.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Display-aspect-ratio-in-viewer.patch
Type: application/octet-stream
Size: 1165 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150808/f31e10b3/attachment-0007.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Ignore-any-current-empty-input.patch
Type: application/octet-stream
Size: 1036 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150808/f31e10b3/attachment-0008.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Try-harder-to-figure-out-the-lens-model.patch
Type: application/octet-stream
Size: 11565 bytes
Desc: not available
URL: <http://mail.kdab.com/pipermail/kphotoalbum/attachments/20150808/f31e10b3/attachment-0009.obj>


More information about the KPhotoAlbum mailing list