[KPhotoAlbum] No Re: KPhotoAlbum 4.4 is out

Miika Turkia miika.turkia at gmail.com
Mon Feb 18 06:31:04 CET 2013


On Sun, Feb 17, 2013 at 8:35 PM, Martin Jost <lists at majo.name> wrote:
> Am 11.02.2013 06:14, schrieb Miika Turkia:
>> The main improvements on this version are support for libkipi 2.0.0
>> and greatly improved save time for the image database. Now it is also
>> possible to remove duplicate images while merging the tags to the
>> remaining image. And naturally a couple of bugs got fixed as well.
>
> Hello,
>
> thanks for KPA 4.4 !
>
> I have a (minor) complain:
> Probably due to the saving speed up, now KPA once more doesn't write a
> final newline to the file.
> I'm keeping index.xml under RCS, so rcsdiff complains about this.
> I then need to readd the newline to make it work.
> Could KPA please write this final newline in the file ?
> (And any hints for me for a quick local fix ?)

Should be fixed now on master.

miika

--- a/XMLDB/FileWriter.cpp
+++ b/XMLDB/FileWriter.cpp
@@ -65,6 +65,7 @@ void XMLDB::FileWriter::save( const QString&
fileName, bool isAutoSave )
         saveBlockList( writer );
         saveMemberGroups( writer );
     }
+    writer.writeEndDocument();

     // State: index.xml has previous DB version, index.xml.tmp has
the current version.


More information about the KPhotoAlbum mailing list