[KPhotoAlbum] Visual Updates for KPA

Andreas Neustifter andreas.neustifter at gmail.com
Sun Jun 19 08:54:34 CEST 2011


Hi!

On 18 June 2011 11:50, Jesper K. Pedersen <blackie at kde.org> wrote:
> I'm not sure I see any visual changes, and I can't see your flicker page.
> Anyway, I've pulled and pushed your changes.

:-) Thats good, it means the changes were no obtrusive and fit in nicely.

> The last one did not work, due to an earlier patch (the email thing I wrote to
> you in private). I'll pull that once you've fixed that and rebased.

Sent you a message with the properly rebased stuff.

> Why did you remove this code though:
> -void MainWindow::StatusBar::setupFixedFonts()
> -{
> -    // Avoid flicker in the statusbar when moving over dates from the datebar
> -    QFont f( font() );
> -    f.setStyleHint( QFont::TypeWriter );
> -    f.setFamily( QString::fromLatin1( "courier" ) );
> -    f.setBold( true );
> -    setFont( f );
> -}

I think that a UI should contain as little different fonts as
possible, the typewriter font in the status bar always struck me as
unnecessary.

Usually either a change in position or a font-change is used to
differentiate information from each other, since in this case the
information has its own positing (the status bar) its not necessary to
change the font too.

Am I being understandable? Change judge...

Andi


More information about the KPhotoAlbum mailing list