[KPhotoAlbum] Thumbnail Sizes

Robert Krawitz rlk at alum.mit.edu
Tue Jun 7 01:54:05 CEST 2011


On Mon, 6 Jun 2011 21:05:33 +0200, Jesper K. Pedersen wrote:
> Too much indirection in my taste. I'll apply the increment of
> default, but skip the extra class.

I don't care whether the defaults are in a separate class or not; they
should be explicit (either #define's or const variables) rather than
embedded in the code.

> On Sunday 05 June 2011 00:19:32 Andreas Neustifter wrote:
>> Hi Jesper!
>> 
>> On 30 May 2011 21:22, Jesper K. Pedersen <blackie at kde.org> wrote:
>> > Sorry, I'm just getting up to speed with KPA again. When trying to apply
>> > the patch it failed. Please send me a new one.
>> 
>> No worries, good to see you again!
>> 
>> Here you go:
>> https://github.com/astifter/kphotoalbum-fork/commit/b4bdb6e645d83ca38e8ee1
>> e219c887e9fcd031f2
>> 
>> This patch simply allows the thumbnail size SpinBox in the settings to
>> properly show the configured values (even when resized via the mouse
>> wheel) and also has a proper range for modern monitors.
>> 
>> I also picked up on the suggestion by Robert Krawitz to put the
>> constants into a separate class. Not sure if this really is the way to
>> go tough...
>> 
>> And because I has not been said in a long time: still using KPA and
>> really liking it, thank you and all the contributors for it!
>> 
>> Kind regards from Vienna, Austria,


More information about the KPhotoAlbum mailing list