[KPhotoAlbum] Very experimental image-grouping patch

Paul Fleischer paul at xpg.dk
Wed Nov 28 13:19:22 CET 2007


2007/11/28, Baptiste MATHUS <ml at batmat.net>:
>
>
> 2007/11/28, Jan Kundrát <jkt at gentoo.org>:
> > Paul Fleischer wrote:
> > > As i wrote in a comment to Bug 152438, I have created a very
> > > experimental system for grouping images in KPhotoAlbum.
> >
> > Wow, looks good.
>
> I didn't have a look yet. I'll try to try in the next days :-).
Great, looking forward to your comments. And I'll probably have a
revised patch ready soon :-)


> > Some comments that I have at a first glance:
> >
> > b) You've used another whitespace convention, you should've used 4
> > spaces per indent
>
> Surely I'm out of the way, moreover I didn't look at the code about it.
> But shouldn't this indentation size (done by spaces if I understand
> correctly) be put in some global parameter ?
> This way we could later consider to allow defining new size for this
> identation ?

Jan comments on my indentation of the source code. I forgot
indentation several places.

/Paul


More information about the KPhotoAlbum mailing list