[KPhotoAlbum] Very experimental image-grouping patch

Baptiste MATHUS ml at batmat.net
Wed Nov 28 13:11:01 CET 2007


2007/11/28, Jan Kundrát <jkt at gentoo.org>:
>
> Paul Fleischer wrote:
> > As i wrote in a comment to Bug 152438, I have created a very
> > experimental system for grouping images in KPhotoAlbum.
>
> Wow, looks good.


I didn't have a look yet. I'll try to try in the next days :-).

Some comments that I have at a first glance:
>
> b) You've used another whitespace convention, you should've used 4
> spaces per indent


Surely I'm out of the way, moreover I didn't look at the code about it.
But shouldn't this indentation size (done by spaces if I understand
correctly) be put in some global parameter ?
This way we could later consider to allow defining new size for this
identation ?

Cheers.

-- 
Baptiste <Batmat> MATHUS
BMathus at Batmat point net - http://batmat.net
Si chacun de nous a une idée et que nous les partageons, nous
repartirons tous les deux avec deux idées... C'est ça le Libre.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /mailman/pipermail/kphotoalbum/attachments/20071128/c4c6b2a1/attachment.html 


More information about the KPhotoAlbum mailing list