[KPhotoAlbum] [Bug 145309] make "show this image" load all images in current view

Robert L Krawitz rlk at alum.mit.edu
Fri May 25 13:41:48 CEST 2007


   From: Michael J Gruber <michaeljgruber+gmane at fastmail.fm>
   Date: Fri, 25 May 2007 13:06:02 +0200

   Robert L Krawitz venit, vidit, dixit 24.05.2007 14:01:
   >    Date: Thu, 24 May 2007 14:49:11 +0300
   >    From: Tuomas Suutari <thsuut at utu.fi>
   >    Cc: kphotoalbum at kdab.net
   > 
   >    On Thursday 24 May 2007 14:37, Robert L Krawitz wrote:
   >    > Jan Kundrát wrote:
   >    > > Robert L Krawitz wrote:
   >    > > > 1) Viewing a RAW image (a .crw, to be precise) does not rotate
   >    > > > the image if it was taken in vertical orientation (it previously
   >    > > > did, as of about a month ago).
   >    > >
   >    > > Could you try to track down what SVN commit broke that?
   >    >
   >    > I'll try, but I won't have a huge amount of time for this.
   > 
   >    Maybe it was rev 650383?
   > 
   >    Though I tested that change and it worked fine with all the test raw 
   >    files I have.
   > 
   >    Here's the commit message:
   > 
   >    SVN commit 650383 by suutari:
   > 
   >    Apply Michael J Gruber's patch to fix rotating raw files (or their
   >    thumbnails) twice.
   > 
   >    See
   >    http://mail.kdab.net/mailman/pipermail/kphotoalbum/2007-February/002776.html
   >    for more details.
   > 
   > That did it.  I had never had problems with rotating RAW files
   > correctly in the first place; that fix is what broke it for me.
   > Undoing that fix solved this.

   Have you tried recreating the thumbnail? The problem is that the
   old code used to rotate thumbnails when creating them, which is
   wrong for several reasons. The new versions stores the thumbnails
   as they are; the display code checks for rotation flags in the db
   and applies that to thumbnails as well as full size images.

Well no, I didn't try recreating the thumbnail.


More information about the KPhotoAlbum mailing list