[KPhotoAlbum] [Bug 145309] make "show this image" load all images in current view

Robert L Krawitz rlk at alum.mit.edu
Fri May 25 01:44:30 CEST 2007


   Date: Fri, 25 May 2007 00:42:27 +0200
   From: =?ISO-8859-1?Q?Jan_Kundr=E1t?= <jkt at gentoo.org>

   Jan Kundrát wrote:
   > Yup, I'm aware of that, but I haven't tested it yet so I don't propose 
   > the change. I'm not sure how would Viewer react if it's told to show 
   > image 123 and images 100 - 110 aren't readable, for example.
   > 
   > And if we change this, we should do the same for Ctrl+A (select all images).

   Please see the attached patch that addresses those two issues and
   tries to "skip" those non-existant images when viewing. This
   auto-skipping could be a bit confusing because commands like "seek
   100 images back" don't take these "holes" into account...

   I've also changed one iterator to a constant one. It compiles and
   works fine, so I guess it's a safe change.

It seems to solve the problem.

Note that in any event KPA has to be prepared to deal with nonexistent
images -- an image may be deleted between when KPA scans and when
someone tries to look at it.


More information about the KPhotoAlbum mailing list