[KPhotoAlbum] [Bug 145309] make "show this image" load all images in current view

Robert L Krawitz rlk at alum.mit.edu
Thu May 24 14:01:42 CEST 2007


   Date: Thu, 24 May 2007 14:49:11 +0300
   From: Tuomas Suutari <thsuut at utu.fi>
   Cc: kphotoalbum at kdab.net

   On Thursday 24 May 2007 14:37, Robert L Krawitz wrote:
   > Jan Kundrát wrote:
   > > Robert L Krawitz wrote:
   > > > 1) Viewing a RAW image (a .crw, to be precise) does not rotate
   > > > the image if it was taken in vertical orientation (it previously
   > > > did, as of about a month ago).
   > >
   > > Could you try to track down what SVN commit broke that?
   >
   > I'll try, but I won't have a huge amount of time for this.

   Maybe it was rev 650383?

   Though I tested that change and it worked fine with all the test raw 
   files I have.

   Here's the commit message:

   SVN commit 650383 by suutari:

   Apply Michael J Gruber's patch to fix rotating raw files (or their
   thumbnails) twice.

   See
   http://mail.kdab.net/mailman/pipermail/kphotoalbum/2007-February/002776.html
   for more details.

That did it.  I had never had problems with rotating RAW files
correctly in the first place; that fix is what broke it for me.
Undoing that fix solved this.

BTW, I notice that with only a small number of images in the thumbnail
viewer, it still took a very long time on a cold system to show an
image if I double click on it.  I suggest that KPA never blindly
attempt to access a potentially large collection of files unless it's
going to immediately read from them.

This is what I suspect the problem is.  Personally, I'd much rather
have it skip an image when it tries to load it, and if it really does
find no images, emit an error then.

void MainWindow::Window::slotView( bool reuse, bool slideShow, bool random )
{
    launchViewer( selectedOnDisk(), reuse, slideShow, random );
}

-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

Tall Clubs International  --  http://www.tall.org/ or 1-888-IM-TALL-2
Member of the League for Programming Freedom -- mail lpf at uunet.uu.net
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton


More information about the KPhotoAlbum mailing list