[KPhotoAlbum] [PATCH] thumbnail aspect ratio & customizable grid

Risto H. Kurppa risto at kurppa.fi
Thu May 10 08:31:37 CEST 2007


Could people in the future attach patches as files, not as text.. Long
lines are cut to multiple lines (stupid e-mail, I wonder when they
come up with 'email 2.0) so it's a bother to try - get an error
message of a malformed line - fix - try.. And in the end fail for some
reason. Well, I'll just try it again..

Anyway, I think it looks great, I like it, great, cool, wow! Though as
you said, sometimes it fails with image names and lets the image
overlap a bit with the name or actually some of the names are
positioned too high, a bit above the line, where they should be (and
where most of the names are). Looks like if the image name is too
long, it creates another (empty) row under it. Should there be some
kind of limit for the length of the names that correlates with the
image cell width or something to prevent splitting in multiple rows -
or then sometihng that creates more space for the name to appear
fully.


And my jpeg's created from NEF*s still don't rotate correctly - they
just don't rotate.. or actually they might be rotated once too much..
I wonder where's the error - either I rotate them already when
exporting jpeg from nef and the copy the same exif - that makes KPA
rotate it once more.. Well, let's see..

Anyway, patch & images look good now, thanks Jan!

The patch is attached here as file for easier use.


r

-- 
rhk

| risto h. kurppa
| risto at kurppa dot fi
| http://risto.kurppa.fi
| http://rhkrhk.jaiku.com <-- uusi


2007/5/10, Jan Kundrát <jkt at gentoo.org>:
> The attached patch makes "grid aspect ratio" customizable and integrates
> former patch that allows grid to be turned off. It also changes default
> values to "dark background with no grid". Aspect ratio is still 1:1 by
> default, although I'd personally consider chaning it to 4:3 or 3:2 by
> default.
>
> Any feedback is welcome :).
>
> Cheers,
> -jkt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_20070509_thumbnails.patch
Type: text/x-diff
Size: 14352 bytes
Desc: not available
Url : /mailman/pipermail/kphotoalbum/attachments/20070510/0126cc7c/attachment-0001.bin 


More information about the KPhotoAlbum mailing list