[KPhotoAlbum] Improved Image Viewer? [PATCH]

Jesper K. Pedersen blackie at blackie.dk
Tue Jan 9 00:46:26 CET 2007


Finally got a bit of post 3.0 time for looking at this patch.

First and foremost. Thanks for the work you have put into it so far, it looks 
really good, both feature wise and the code. I hope I will see work coming in 
from you in a regular interval in the future :-)

Attached is a counter patch, please look at all the places I've added a 
PENDING to fix the things requested.

Here are a few general comments:
- When I tried it, I just went to the thumbnails for all my images, selected 
one, and pressed enter. After a minute I killed my KPA, still having seen the 
viewer, and with a harddisk spinning like mad. 
I guess it goes without saying that, that needs to be fixed :-)

- In the viewerer I now found myself trying to go previous/next by pressing 
left/right arrow, could you please make these key bindings.

- Please see attached screen shot, it seems like the info box doesn't grow to 
take extra vertical space when the thumbnail size are made bigger.

- when I have say 20 pictures in current view, and I choose to select the last 
one, then the bar highlights this thumbnail, but doesn't scroll to it.

- Did you ask the original authors for permission to use the bar? License wise 
we dont need to, but I'd like to stay friendly with the digikam team, so we 
should at least give them a chance to allow us.

- It would be awesome if was possible to make the bar hide at the bottom of 
the screen, and only show up when mouse was moved to the lowest few pixels 
(similar to what gwenview has for showing image info). Nice appearing effect 
should be rather easy to implement :-) It would also be usefull if it was 
possible to make it sticky, so it stayed up (something like the way you can 
make windows sticky in KDE in general)

- It would be cool if the thumbnail slider could be resized with the middle 
mouse button as is the case for the thumbnail view.

Cheers
Jesper.

On Sunday 31 December 2006 23:04, Jason Kivlighn wrote:
| Sorry, that patch didn't include new files added.
|
| Cheers,
| Jason Kivlighn
|
| On 12/31/06, Jason Kivlighn <jkivlighn at gmail.com> wrote:
| > Here you go.  I just ran 'svn up' and recreated the patch.  It seems to
| > have merged all the files correctly.
| >
| > Cheers,
| > Jason Kivlighn
| >
| > On 12/31/06, Baptiste MATHUS <ml at batmat.net> wrote:
| > > I'd like to test it, but I just updated to the trunk and it does not
| > > seem to be applicable. If you have some time to just adapt your patch
| > > to this revision, I'd be glad to review it (from a user perspective):
| > >
| > >  $ svn info
| > > Path: .
| > > URL:
| > > svn://anonsvn.kde.org/home/kde/trunk/extragear/graphics/kphotoalbum
| > > Repository Root: svn://anonsvn.kde.org/home/kde
| > > Repository UUID: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
| > > Revision: 618181
| > > Node Kind: directory
| > > Schedule: normal
| > > Last Changed Author: blackie
| > > Last Changed Rev: 618129
| > > Last Changed Date: 2006-12-31 11:06:57 +0100 (dim, 31 déc 2006)
| > >
| > > Thanks.
| > >
| > > 2006/12/30, Jason Kivlighn <jkivlighn at gmail.com>:
| > > >  Hello again,
| > > >
| > > > I've cleaned up the patch quite a bit and made the thumbnail size
| > > > configurable.  Other than that, it pretty much works as originally
| > > > proposed.
| > > >
| > > > If it needs work to be accepted, I'm open to hearing it and getting
| > > > it fixed.
| > > >
| > > > Cheers,
| > > > Jason Kivlighn
| > > > _______________________________________________
| > > > KPhotoAlbum mailing list
| > > > KPhotoAlbum at kdab.net
| > > > http://mail.kdab.net/mailman/listinfo/kphotoalbum
| > >
| > > --
| > > Baptiste <Batmat> MATHUS
| > > BMathus at Batmat point net - http://batmat.net
| > > ---------
| > > Si chacun de nous a une idée et que nous les partageons, nous
| > > repartirons tous les deux avec deux idées... C'est ça le Libre.
| > >
| > > _______________________________________________
| > > KPhotoAlbum mailing list
| > > KPhotoAlbum at kdab.net
| > > http://mail.kdab.net/mailman/listinfo/kphotoalbum

-- 
Having trouble finding a given image in your collection containing
thousands of images?

http://www.kphotoalbum.org might be the answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: see.jpg
Type: image/jpeg
Size: 19102 bytes
Desc: not available
Url : /mailman/pipermail/kphotoalbum/attachments/20070109/00610bf8/attachment-0001.jpg 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new-patch
Type: text/x-diff
Size: 55081 bytes
Desc: not available
Url : /mailman/pipermail/kphotoalbum/attachments/20070109/00610bf8/attachment-0001.bin 


More information about the KPhotoAlbum mailing list