[KPhotoAlbum] Latest patch

Jesper K. Pedersen blackie at blackie.dk
Sun Jul 9 13:03:00 CEST 2006

First of all, good work. Sorry for not responding earlier but my dad was 
hospitalized so I had to abrupt a holiday and rush home, so KPA suddenly got 
lower priority :-o

I have a few request I'd like you to look at before we finalize this, please 
read on. 

I've made so changes to the code in the meantime, so your patch doesn't commit 
cleanly, so please find attached your patch made against the current trunk.
| 1) A new option to permit smooth scaling vs. non-smoothed scaling
|    (which is much, much faster, particularly with large images).  I
|    think there's still an issue with image preloading sometimes taking
|    priority over responding to a user command in at least some cases
|    (so that sometimes there's a short pause that I don't think is
|    strictly necessary), but image display is a *lot* faster if smooth
|    scaling is turned off.
Without having looked to much at the code yet, I assume this is only in the 
viewer, and not for thumbnails, right?
Being completely blind towards details uglyness (I really couldn't see that 
anything was wrong with the thumbnails back in the old days when I did not 
smoothscale them), can you tell me how much worse non smooth scale looks when 
viewing, and how much faster it is.

| 2) A new viewer option to permit showing image size in the info box.

| 3) A new viewer option to permit showing file name in the info box.
With this turned on, we now get both vertical and horizontal scrollbars, which 
looks odd. It would be cool if you could look into why we get the vertical 
ones, they should not be needed, should they.
I think I'll make this non-shown by default, as I believe most KPA users won't 
need it.

| 4) An option to allow specifying thumbnail size.
Why would you want this? All you have to do is grab the thumbnail view with 
the middle mouse button and drag, to resize.

If it simple is a matter of not having recognized this yet, and you agree that 
we do not need this options, then please remove this code from the patch.

| 5) A new command in the viewer to zoom pixel for pixel (if the image
|    is larger than the viewer, of course :-( ) -- typing `=' will do
|    this.

| 6) Ability to scale to less than full screen.  This means that
|    displaying pixel for pixel will always display pixel for pixel, in
|    addition to the ability to zoom out beyond that point.
And that was even an easy fix I see :-) It really makes me wonder why I ever 
put in that restriction.

| 7) A new "standard size" setting, which can be one of three things:
|    * Full screen (the default, as today)
|    * Natural size (i. e. pixel for pixel)
|    * Natural size if possible (pixel for pixel if it would fit,
|      otherwise full screen).
|    In addition to being saved in the preferences, typing the `/' key
|    at any time will display the image at "standard size".
I don't really get it (tm), if I press the / on an image 100x120, shouldn't I 
see it this size, rather than scaled up? That doesn't seem to work for me.

If I choose to see things in standard view, will all subsequent images also be 
shown in standard view (I believe that would be the coolest).

|    This isn't perfect.  In at least some cases it initially flashes
|    the image at full size before rescaling it up or down.  Fixing this
|    will require more extensive work.  In particular, doing most
|    efficiently will require reorganizing the cache so that it actually
|    keeps track of the image sizes rather than assuming that they're at
|    the display size, and the cache code in general will require some
|    work.  I probably won't have time to do this before I go back to
|    work.
Could you tell me what you do to see this flashing?

| 8) New options to skip forward and backward by 10, 100, and 1000
|    images.  This was inspired by our 3500 photos from Alaska that
|    we're trying to categorize.  We did some of them last night, and I
|    want to restart in the middle (I know where we left off, but it's a
|    pain to find it in the thumbnail view and then select everything
|    from that point on).
Again, this is only in the viewer, right?
If you have time, it would be cool if lots of the things in the viewers 
context menus could be put into submenus. At least on my laptop, the menu now 
is way to big.

I at some point saw that "skip 1000 images backward" was disabled, but it 
seems random what menu item are disabled. I loaded three images, and I see 
all the skip entries enabled, except the 1000 backwards.

| 9) The display code checks if the stored size is -1 (i. e. KPhotoAlbum
|    doesn't know what size it is), and fixes it up (and calls back to
|    the viewer to update the image box).  This could happen in cases
|    other than already-present thumbnails; for example, if you try to
|    view images for which thumbnails aren't yet created.
I trust you that this is correct.

| 10) A new option to specify whether or not to load RAW files if
|    corresponding JPEG or TIFF files also exist.  Default is that it
|    doesn't, which is a change from the current behavior.  This is
|    useful with cameras that store both a raw image and a JPEG or
|    TIFF.  Related to this, I've changed the new image finder code to
|    pass the entire filename to canReadImage rather than just the file
|    extension.  I believe this is the right thing to do because it
|    allows the code to determine whether it actually can read the file
|    or not.
I've been tinkering with this issue for some time, without finding the time to 
do something real about it.
Lets just keep it in for now, but could you please make it off by default 

Finally, I loaded in a big image, and zoomed out of it till it was smaller 
than the screen, and suddenly my computer froze, could you please check if we 
end up creating huge pixmaps to show them really tiny, or what goes on here.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch
Type: text/x-diff
Size: 40280 bytes
Desc: not available
Url : /mailman/pipermail/kphotoalbum/attachments/20060709/d3737428/patch-0001.bin

More information about the KPhotoAlbum mailing list