[KimDaBa] A couple more patches

Jesper K. Pedersen blackie at blackie.dk
Sun Jan 9 20:30:29 CET 2005


On Saturday 08 January 2005 02:00, Robert L Krawitz wrote:
| 1) This is the correct fix to handle .thm files (next to .crw files).
|    I didn't realize that QString::baseName() strips off the leading
|    directory.  I guess when I tested it I ran kimdaba out of the
|    directory where the files actually lived.
Thx, applied

| 2) The first block in this change flushes the thumbnail cache when the
|    thumbnail size changes.  This solved a number of redisplay problems
|    I was having -- not all of them, but it certainly solved a problem
|    I had when I changed the thumbnail size.
|
|    (BTW, why is the cache size of 4K hard coded?)
Its 4Mb, for no reason in particular ;-)
This was my original suggestion for a size and that worked well - maybe one 
day I'll make it customizable.

|    The second block (that's currently #ifdef'ed out) may or may not be
|    important.  It seems very strange to me to return an empty pixmap
|    when it isn't found in cache, but there may be a reason why.
Well the images is loaded on a secondary loader thread, which will return the 
image, and when the image get back the code in pixmapLoaded will call 
repaintItem, which will call the pixmap method again.

Cheers
Jesper.



More information about the KimDaBa mailing list